Rollup of 4 pull requests by JonathanBrouwer · Pull Request #152002 · rust-lang/rust

JonathanBrouwer · 2026-02-02T16:23:58Z

Successful merges:

Add codegen test for SLP vectorization #151958 (Add codegen test for SLP vectorization)
Update documentation for Result::ok() #151974 (Update documentation for Result::ok())
Work around rustfmt giving up on a large expression #151975 (Work around rustfmt giving up on a large expression)
attribute parsing: pass recovery mode to Parser. #151999 (attribute parsing: pass recovery mode to Parser.)

The term of "discard" is misleading. An error is not discarded but converted to an `Option::None`.

Co-authored-by: Nikita Popov <github@npopov.com>

…-test, r=jieyouxu Add codegen test for SLP vectorization close: rust-lang#142519 This PR adds a codegen regression test for rust-lang#142519. A regression in LLVM to fail to auto-vectorize, leading to significant performance loss. The SLP vectorizer correctly groups the 4-byte operations into <4 x i8> vectors. The loop state is maintained in SIMD registers (phi <4 x i8>). The test remains robust across architectures (AArch64 vs x86_64) by allowing flexible store types (i32 or <4 x i8>).

Update documentation for `Result::ok()` The term of "discard" is misleading. An error is not discarded but converted to an `Option::None`.

Work around rustfmt giving up on a large expression - rust-lang/rustfmt#3863 --- In some cases, if rustfmt sees a string literal that is too long for it to comfortably format, it will give up on formatting the entire enclosing expression. For complex builder expressions, that will prevent auto-formatting for frustratingly large sections of code. This PR works around a particular occurrence of that phenomenon in `compiler/rustc_interface/src/util.rs`, by splitting a single error message string across multiple lines. This allows rustfmt to successfully auto-format the entire enclosing expression, which is dozens of lines long. There should be no change to compiler behaviour.

…nBrouwer attribute parsing: pass recovery mode to Parser. Fixes rust-lang#151996

JonathanBrouwer · 2026-02-02T16:24:11Z

@bors r+ rollup=never p=5

rust-bors · 2026-02-02T16:24:13Z

📌 Commit 8e39986 has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 4 pull requests Successful merges: - #151958 (Add codegen test for SLP vectorization) - #151974 (Update documentation for `Result::ok()`) - #151975 (Work around rustfmt giving up on a large expression) - #151999 (attribute parsing: pass recovery mode to Parser.)

rust-log-analyzer · 2026-02-02T18:16:11Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[group]Runner Image Provisioner
Hosted Compute Agent
Version: 20260123.484
Commit: 6bd6555ca37d84114959e1c76d2c01448ff61c5d
Build Date: 2026-01-23T19:41:17Z
Worker ID: {92451d50-c998-4965-a290-e09bab1075d1}
Azure Region: westcentralus
##[endgroup]
##[group]Operating System
Ubuntu
24.04.3
LTS
---
REPOSITORY                                   TAG       IMAGE ID       CREATED      SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    bcec0b4e062b   7 days ago   783MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:b662be51f7b8ef7e2c8464428f14e49cb79c36aa9afb7ecb9221dfe0f507050c
deleted: sha256:bcec0b4e062b5ffe11cc1c2729558c0cd96621c0271ab5e97ff3a56e0c25045a
deleted: sha256:64e147d5e54d9be8b8aa322e511cda02296eda4b8b8d063c6a314833aca50e29
deleted: sha256:5cba409bb463f4e7fa1a19f695450170422582c1bc7c0e934d893b4e5f558bc6
deleted: sha256:cddc6ebd344b0111eaab170ead1dfda24acdfe865ed8a12599a34d338fa8e28b
deleted: sha256:2412c3f334d79134573cd45e657fb6cc0abd75bef3881458b0d498d936545c8d
---
tests/ui/drain_collect.fixed ... ok
tests/ui/double_parens.rs ... ok
tests/ui/duplicate_underscore_argument.rs ... ok
tests/ui/duplicated_attributes.rs ... ok
tests/ui/duration_suboptimal_units.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.rs ... ok
tests/ui/duration_subsec.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.fixed ... ok
tests/ui/duration_suboptimal_units.fixed ... ok
tests/ui/double_parens.fixed ... ok
tests/ui/duration_subsec.fixed ... ok
tests/ui/else_if_without_else.rs ... ok
tests/ui/elidable_lifetime_names.rs ... ok
tests/ui/empty_docs.rs ... ok
---
...............................................    (147/147)

======== tests/rustdoc-gui/globals.goml ========

[ERROR] line 14: Error: The window properties still all match: for command `wait-for-window-property-false: {"searchIndex": null}`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/index.html?search=Foo>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

rust-bors · 2026-02-02T18:16:36Z

💔 Test for 6c4ca5e failed: CI. Failed job:

auto - x86_64-gnu-tools (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-02-02T18:18:43Z

@bors retry

rust-bors · 2026-02-02T21:49:13Z

⌛ Testing commit 8e39986 with merge 42fc0fb...

Workflow: https://github.com/rust-lang/rust/actions/runs/21607825908

…uwer Rollup of 4 pull requests Successful merges: - #151958 (Add codegen test for SLP vectorization) - #151974 (Update documentation for `Result::ok()`) - #151975 (Work around rustfmt giving up on a large expression) - #151999 (attribute parsing: pass recovery mode to Parser.)

JonathanBrouwer · 2026-02-02T21:51:27Z

@bors yield
Yielding to the bigger rollup

rust-bors · 2026-02-02T21:51:30Z

Auto build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/21607825908

The next pull request likely to be tested is #152002.

rust-bors · 2026-02-02T21:51:33Z

⌛ Testing commit 8e39986 with merge 3ba4b86...

Workflow: https://github.com/rust-lang/rust/actions/runs/21607878122

…uwer Rollup of 4 pull requests Successful merges: - #151958 (Add codegen test for SLP vectorization) - #151974 (Update documentation for `Result::ok()`) - #151975 (Work around rustfmt giving up on a large expression) - #151999 (attribute parsing: pass recovery mode to Parser.)

JonathanBrouwer · 2026-02-02T21:51:45Z

@bors r- retry

rust-bors · 2026-02-02T21:51:49Z

Commit 8e39986 has been unapproved.

Auto build cancelled due to unapproval. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/21607878122

chahar-ritik and others added 16 commits February 1, 2026 21:41

Add codegen test for SLP vectorization

2292d53

fix: remove trailing newline for tidy

0a60bd6

Restrict test to x86_64 per reviewer feedback

1c396d2

Update documentation for Result::ok()

f3b7a1a

The term of "discard" is misleading. An error is not discarded but converted to an `Option::None`.

Add backlink to issue

c64f9a0

Work around rustfmt giving up on a large expression

0cbbe56

Fix SLP vectorization test CHECK patterns

95ac567

fix: add min-llvm-version

0830a5a

fix: remove space for tidy and only for x86_64

6176945

Update min-llvm-version: 22

8476e89

Co-authored-by: Nikita Popov <github@npopov.com>

Use rustc_parse's Recovery instead of a boolean

30ae46f

Pass Recovery down to rustc_parse's Parser

aef8217

Rollup merge of rust-lang#151974 - clundin55:doc-fix, r=jhpratt

2d5e6dc

Update documentation for `Result::ok()` The term of "discard" is misleading. An error is not discarded but converted to an `Option::None`.

Rollup merge of rust-lang#151999 - mejrs:ignore_nonmeta_v2, r=Jonatha…

8e39986

…nBrouwer attribute parsing: pass recovery mode to Parser. Fixes rust-lang#151996

rust-bors Bot added the rollup A PR which is a rollup label Feb 2, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 2, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 2, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 2, 2026

JonathanBrouwer closed this Feb 3, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 3, 2026

JonathanBrouwer deleted the rollup-7XNKruy branch August 21, 2026 08:06

Navigation Menu

Uh oh!

Uh oh!

Rollup of 4 pull requests - #152002

Rollup of 4 pull requests#152002
JonathanBrouwer wants to merge 16 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-7XNKruy

JonathanBrouwer commented Feb 2, 2026

Uh oh!

JonathanBrouwer commented Feb 2, 2026

Uh oh!

rust-bors Bot commented Feb 2, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Feb 2, 2026

Uh oh!

rust-bors Bot commented Feb 2, 2026

Uh oh!

JonathanBrouwer commented Feb 2, 2026

Uh oh!

rust-bors Bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

JonathanBrouwer commented Feb 2, 2026

Uh oh!

rust-bors Bot commented Feb 2, 2026

Uh oh!

rust-bors Bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

JonathanBrouwer commented Feb 2, 2026

Uh oh!

rust-bors Bot commented Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Feb 2, 2026

Uh oh!

JonathanBrouwer commented Feb 2, 2026

Uh oh!

rust-bors Bot commented Feb 2, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Feb 2, 2026

Uh oh!

rust-bors Bot commented Feb 2, 2026

Uh oh!

JonathanBrouwer commented Feb 2, 2026

Uh oh!

rust-bors Bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Feb 2, 2026

Uh oh!

rust-bors Bot commented Feb 2, 2026

Uh oh!

rust-bors Bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Feb 2, 2026

Uh oh!

rust-bors Bot commented Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rust-bors Bot commented Feb 2, 2026 •

edited

Loading

rust-bors Bot commented Feb 2, 2026 •

edited

Loading